Re: [PATCH] regulator: da9063: remove redundant return statement

From: Mark Brown
Date: Thu Feb 06 2020 - 06:32:52 EST


On Thu, Feb 06, 2020 at 10:06:01AM +0530, Rishi Gupta wrote:
> The devm_request_threaded_irq() already returns 0 on success
> and negative error code on failure. So return from this itself
> can be used while preserving error log in case of failure.
>
> This commit also fixes checkpatch.pl errors & warnings:
> - WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> - WARNING: line over 80 characters
> - ERROR: space prohibited before that ',' (ctx:WxW)
> - ERROR: code indent should use tabs where possible
> - WARNING: Block comments use * on subsequent lines

This should be split into separate patches, each doing one thing
as covered in submitting-patchs.rst.

Attachment: signature.asc
Description: PGP signature