Re: [PATCH v2 09/16] bus: mhi: core: Add support for downloading RDDM image during panic

[Jeffrey Hugo]

On 1/31/2020 6:50 AM, Manivannan Sadhasivam wrote:
> MHI protocol supports downloading RDDM (RAM Dump) image from the
> device through BHIE. This is useful to debugging as the RDDM image
> can capture the firmware state.
>
> This is based on the patch submitted by Sujeev Dias:
> https://lkml.org/lkml/2018/7/9/989
>
> Signed-off-by: Sujeev Dias <sdias@xxxxxxxxxxxxxx>
> Signed-off-by: Siddartha Mohanadoss <smohanad@xxxxxxxxxxxxxx>
> [mani: splitted the data transfer patch and cleaned up for upstream]
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> ---
>   drivers/bus/mhi/core/boot.c     | 157 +++++++++++++++++++++++++++++++-
>   drivers/bus/mhi/core/init.c     |  38 ++++++++
>   drivers/bus/mhi/core/internal.h |   2 +
>   drivers/bus/mhi/core/pm.c       |  31 +++++++
>   include/linux/mhi.h             |  24 +++++
>   5 files changed, 249 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/bus/mhi/core/boot.c b/drivers/bus/mhi/core/boot.c
> index 36956fb6eff2..564d61f98257 100644
> --- a/drivers/bus/mhi/core/boot.c
> +++ b/drivers/bus/mhi/core/boot.c
> @@ -20,7 +20,159 @@
>   #include <linux/wait.h>
>   #include "internal.h"
>   
> -/* Download AMSS image to device */

Seems a bit odd to add this line in patch 8, only to remove it here in 
patch 9.  Feels like never adding it in the first place would be better. 
 Not something to warrant a v3 through.

--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.