Re: [PATCH] drm/virtio: fix ring free check

From: Gerd Hoffmann
Date: Fri Feb 07 2020 - 01:46:55 EST


Hi,

> > + indirect = virtio_has_feature(vgdev->vdev, VIRTIO_RING_F_INDIRECT_DESC);
> > + vqcnt = indirect ? 1 : elemcnt;
> Is the feature dynamic and require the lock held? If not, the result
> can be cached and the fixup can happen before grabbing the lock

Not dynamic, so yes, caching makes sense.

cheers,
Gerd