Re: [PATCH v2 2/2] dt-binding: spi: add bindings for spi-ar934x

From: Chuanhong Guo
Date: Sat Feb 08 2020 - 04:37:43 EST


On Sat, Feb 8, 2020 at 7:54 AM Florian Fainelli <f.fainelli@xxxxxxxxx> wrote:
> On 2/6/20 9:55 PM, Chuanhong Guo wrote:
> > It's caused by "clocks = <&pll ATH79_CLK_AHB>" where ATH79_CLK_AHB
> > isn't defined without a include of dt-bindings/clock/ath79-clk.h
> > I'll replace this with a bogus "clocks = <&spi_clock>" instead in v3.
>
> You can include ath79-clk.h in your example, see for instance
> Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml

Oh. But I've already sent v3 out yesterday :(

I think this is just cosmetic changes and doesn't make much difference
so I'd like to keep v3 as-is now and if there are other comments for
me to send a v4 I'll change this one as well.

Regards,
Chuanhong Guo