Re: [PATCH RESEND] sched: fix kernel-doc warning in attach_entity_load_avg()

From: Vincent Guittot
Date: Mon Feb 10 2020 - 02:41:46 EST


On Mon, 10 Feb 2020 at 04:29, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Fix kernel-doc warning in kernel/sched/fair.c, caused by a recent
> function parameter removal:
>
> ../kernel/sched/fair.c:3526: warning: Excess function parameter 'flags' description in 'attach_entity_load_avg'
>
> Fixes: a4f9a0e51bbf ("sched/fair: Remove redundant call to cpufreq_update_util()")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Vincent Guittot <vincent.guittot@xxxxxxxxxx> (SCHED_NORMAL)
> Cc: Dietmar Eggemann <dietmar.eggemann@xxxxxxx> (SCHED_NORMAL)

Reviewed-by: Vincent Guittot <vincent.guittot@xxxxxxxxxx>

>
> ---
> kernel/sched/fair.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- lnx-56-rc1.orig/kernel/sched/fair.c
> +++ lnx-56-rc1/kernel/sched/fair.c
> @@ -3516,7 +3516,6 @@ update_cfs_rq_load_avg(u64 now, struct c
> * attach_entity_load_avg - attach this entity to its cfs_rq load avg
> * @cfs_rq: cfs_rq to attach to
> * @se: sched_entity to attach
> - * @flags: migration hints
> *
> * Must call update_cfs_rq_load_avg() before this, since we rely on
> * cfs_rq->avg.last_update_time being current.
>
>