Re: [PATCH 1/3] usb: gadget: aspeed: read vhub config from of_device_id

From: Tao Ren
Date: Mon Feb 10 2020 - 14:16:37 EST


On Mon, Feb 10, 2020 at 02:47:02AM +0000, Joel Stanley wrote:
> On Fri, 31 Jan 2020 at 22:22, <rentao.bupt@xxxxxxxxx> wrote:
> >
> > From: Tao Ren <rentao.bupt@xxxxxxxxx>
> >
> > The patch moves hardcoded vhub attributes (maximum downstream ports and
> > generic endpoints) to "ast_vhub_config" structure which is attached to
> > struct of_device_id. The major purpose is to add AST2600 vhub support
> > because AST2600 vhub provides more downstream ports and endpoints.
> >
> > Signed-off-by: Tao Ren <rentao.bupt@xxxxxxxxx>
>
> This looks generally okay. We should wait for Ben's ack before applying.
>
> Reviewed-by: Joel Stanley <joel@xxxxxxxxx>

Thanks Joel for reviewing the patches.

Cheers,

Tao