RE: [PATCH] kunit: run kunit_tool from any directory

From: Bird, Tim
Date: Tue Feb 11 2020 - 13:26:30 EST




> -----Original Message-----
> From: Brendan Higgins
> Sent: Monday, February 10, 2020 5:32 PM
> To: Heidi Fahim <heidifahim@xxxxxxxxxx>; David Gow <davidgow@xxxxxxxxxx>; Daniel Latypov <dlatypov@xxxxxxxxxx>
> Cc: open list:KERNEL SELFTEST FRAMEWORK <linux-kselftest@xxxxxxxxxxxxxxx>; KUnit Development <kunit-dev@xxxxxxxxxxxxxxxx>; Linux
> Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
> Subject: Re: [PATCH] kunit: run kunit_tool from any directory
>
> On Mon, Feb 10, 2020 at 4:26 PM Heidi Fahim <heidifahim@xxxxxxxxxx> wrote:
> >
> > Implemented small fix so that the script changes work directories to the
> > linux directory where kunit.py is run. This enables the user to run
> > kunit from any working directory. Originally considered using
> > os.path.join but this is more error prone as we would have to find all
> > file path usages and modify them accordingly. Using os.chdir ensures
> > that the entire script is run within /linux.
> >
> > Signed-off-by: Heidi Fahim <heidifahim@xxxxxxxxxx>
>
> Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
>
Sorry - I'm not a current kunit user, but does this mean that the
kernel source has to be present in order to run the unit tests?
That's problematical for embedded systems. Maybe that's outside
the scope of what unit tests were envisioned for?
-- Tim