Re: [PATCH] iommu/arm-smmu: fix the module name to be consistent with older kernel

From: Will Deacon
Date: Wed Feb 12 2020 - 05:49:10 EST


On Tue, Feb 11, 2020 at 06:37:20PM -0600, Li Yang wrote:
> Commit cd221bd24ff5 ("iommu/arm-smmu: Allow building as a module")
> introduced a side effect that changed the module name from arm-smmu to
> arm-smmu-mod. This breaks the users of kernel parameters for the driver
> (e.g. arm-smmu.disable_bypass). This patch changes the module name back
> to be consistent.
>
> Signed-off-by: Li Yang <leoyang.li@xxxxxxx>
> ---
> drivers/iommu/Makefile | 4 ++--
> drivers/iommu/{arm-smmu.c => arm-smmu-common.c} | 0
> 2 files changed, 2 insertions(+), 2 deletions(-)
> rename drivers/iommu/{arm-smmu.c => arm-smmu-common.c} (100%)

Can't we just override MODULE_PARAM_PREFIX instead of renaming the file?

Will