Re: [PATCH 2/2] mm: vmpressure: use mem_cgroup_is_root API

From: David Hildenbrand
Date: Wed Feb 12 2020 - 06:19:55 EST


On 11.02.20 06:24, Yang Shi wrote:
> Use mem_cgroup_is_root() API to check if memcg is root memcg instead of
> open coding.
>
> Signed-off-by: Yang Shi <yang.shi@xxxxxxxxxxxxxxxxx>
> ---
> mm/vmpressure.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmpressure.c b/mm/vmpressure.c
> index 0590f00..d69019f 100644
> --- a/mm/vmpressure.c
> +++ b/mm/vmpressure.c
> @@ -280,7 +280,7 @@ void vmpressure(gfp_t gfp, struct mem_cgroup *memcg, bool tree,
> enum vmpressure_levels level;
>
> /* For now, no users for root-level efficiency */
> - if (!memcg || memcg == root_mem_cgroup)
> + if (!memcg || mem_cgroup_is_root(memcg))
> return;
>
> spin_lock(&vmpr->sr_lock);
>

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Thanks,

David / dhildenb