Re: [PATCH devicetree 3/4] arm64: dts: fsl: ls1028a: add node for Felix switch

From: Andrew Lunn
Date: Mon Feb 17 2020 - 10:29:22 EST


Hi Vladimir

> + /* Internal port with DSA tagging */
> + mscc_felix_port4: port@4 {
> + reg = <4>;
> + phy-mode = "gmii";

Is it really using gmii? Often in SoC connections use something else,
and phy-mode = "internal" is more appropriate.

> + ethernet = <&enetc_port2>;
> +
> + fixed-link {
> + speed = <2500>;
> + full-duplex;
> + };

gmii and 2500 also don't really go together.

Andrew