Re: [PATCH v4 1/3] dt-bindings: add device tree binding for Arm CryptoCell trng engine

From: Rob Herring
Date: Tue Feb 18 2020 - 15:22:32 EST


On Sun, 16 Feb 2020 12:04:08 +0200, Hadar Gat wrote:
> The Arm CryptoCell is a hardware security engine. This patch adds DT
> bindings for its TRNG (True Random Number Generator) engine.
>
> Signed-off-by: Hadar Gat <hadar.gat@xxxxxxx>
> ---
> .../devicetree/bindings/rng/arm-cctrng.yaml | 50 ++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rng/arm-cctrng.yaml
>

My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rng/arm-cctrng.yaml: properties:arm,rosc-ratio: {'allOf': [{'$ref': '/schemas/types.yaml#/definitions/uint32-array'}], 'maxItems': 4} is not valid under any of the given schemas (Possible causes of the failure):
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rng/arm-cctrng.yaml: properties:arm,rosc-ratio: 'description' is a required property

Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/rng/arm-cctrng.example.dts' failed
make[1]: *** [Documentation/devicetree/bindings/rng/arm-cctrng.example.dts] Error 1
Makefile:1263: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2

See https://patchwork.ozlabs.org/patch/1238733
Please check and re-submit.