Re: [PATCH v6 0/4] leds: trigger: implement a tty trigger

From: Greg Kroah-Hartman
Date: Wed Feb 19 2020 - 05:40:17 EST


On Thu, Feb 13, 2020 at 10:15:56AM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>
> Hello,
>
> This is v6 of my quest to introduce ledtriggers for UARTs. The previous
> series is available at
>
> http://lore.kernel.org/r/20191219093947.15502-1-u.kleine-koenig@xxxxxxxxxxxxxx
>
> The changes compared to that are that parsing of the dev parameter is
> more strict and that I set brightness directly from the kworker instead
> of using led_blink_set_oneshot which makes use of another kworker. (Both
> requested by Pavel Machek.)
>
> For the former I introduced a new helper kstrtodev_t() in the spirit of
> kstrtoul() to implement the stricter parsing (instead of the lax one
> using plain sscanf() in v5).

Looks good to me, Pavel, any objection to me merging this through the
tty tree?

thanks,

greg k-h