Re: [PATCH 2/3] btrfs: remove set but not used variable 'parent'

From: Nikolay Borisov
Date: Wed Feb 19 2020 - 06:35:03 EST




On 19.02.20 Ð. 13:22 Ñ., yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> fs/btrfs/tree-log.c: In function âwalk_down_log_treeâ:
> fs/btrfs/tree-log.c:2702:24: warning: variable âparentâ
> set but not used [-Wunused-but-set-variable]
> fs/btrfs/tree-log.c: In function âwalk_up_log_treeâ:
> fs/btrfs/tree-log.c:2803:26: warning: variable âparentâ
> set but not used [-Wunused-but-set-variable]
>
> They are never used, and so can be removed.
>
> Signed-off-by: yu kuai <yukuai3@xxxxxxxxxx>

Ah yes, those two are a result of my :

e084c5ab48f9 ("btrfs: Call btrfs_pin_reserved_extent only during active
transaction") (in misc-next branch)

David perhaps you can squash the two var removals into the original patch?


Reviewed-by: Nikolay Borisov <nborisov@xxxxxxxx>