Re: [PATCH] staging: comedi: change CamelCase to CAPS

From: Greg Kroah-Hartman
Date: Wed Feb 19 2020 - 13:46:21 EST

On Wed, Feb 19, 2020 at 11:16:46PM +0530, Kaaira Gupta wrote:
> fix check of 'Avoid CamelCase' by changing NI_CtrSource to
> NI_CTRSOURCE in all the files. Change it to CAPS because it is a MICRO

What is a "MICRO"?

> Signed-off-by: Kaaira Gupta <kgupta@xxxxxxxxxxxxx>

Are you sure this is ok? I think this comes directly from a spec sheet
so changing it might not be good.

as proof:

> @@ -104,7 +104,7 @@ struct ni_device_routes ni_pci_6070e_device_routes = {
> {
> .dest = TRIGGER_LINE(0),
> .src = (int[]){
> - NI_CtrSource(0),
> NI_CtrGate(0),
> NI_CtrInternalOutput(0),
> NI_CtrOut(0),

Looks like all of these are CamelCase, why are you changing only one?
They all should be the same, and odds are, how they are today is fine,

Look at the git history of these files to be sure.


greg k-h