Re: [PATCH 3/6] tracing: Wrap section comparison in tracer_alloc_buffers with COMPARE_SECTIONS
From: Jason Gunthorpe
Date: Wed Feb 19 2020 - 14:54:28 EST
On Wed, Feb 19, 2020 at 11:11:19AM -0800, Nick Desaulniers wrote:
> > Godbolt says clang is happy if it is written as:
> > if (&__stop___trace_bprintk_fmt != &__start___trace_bprintk_fmt)
> > Which is probably the best compromise. The type here is const char
> > *, so it would be a shame to see it go.
> If the "address" is never dereferenced, but only used for arithmetic
> (in a way that the the pointed to type is irrelevant), does the
> pointed to type matter?
The type is used here:
if (*pos < start_index)
return __start___trace_bprintk_fmt + *pos;
The return expression should be a const char **
Presumably the caller of find_next derferences it.