Re: [PATCH v3 05/10] ASoC: tegra: add Tegra210 based AHUB driver
From: Jon Hunter
Date: Thu Feb 20 2020 - 10:08:11 EST
On 20/02/2020 06:34, Sameer Pujar wrote:
> The Audio Hub (AHUB) comprises a collection of hardware accelerators for
> audio pre/post-processing and a programmable full crossbar (XBAR) for
> routing audio data across these accelerators in time and in parallel.
> AHUB supports multiple interfaces to I2S, DSPK, DMIC etc., XBAR is a
> switch used to configure or modify audio routing between HW accelerators
> present inside AHUB.
> This patch registers AHUB component with ASoC framework. The component
> driver exposes DAPM widgets, routes and kcontrols for the device. The DAI
> driver exposes AHUB interfaces, which can be used to connect different
> components in the ASoC layer. Currently the driver takes care of XBAR
> programming to allow audio data flow through various clients of the AHUB.
> Makefile and Kconfig support is added to allow to build the driver. The
> AHUB component can be enabled in the DT via below compatible bindings.
> - "nvidia,tegra210-ahub" for Tegra210
> - "nvidia,tegra186-ahub" for Tegra186 and Tegra194
> Signed-off-by: Sameer Pujar <spujar@xxxxxxxxxx>
> sound/soc/tegra/Kconfig | 10 +
> sound/soc/tegra/Makefile | 2 +
> sound/soc/tegra/tegra210_ahub.c | 651 ++++++++++++++++++++++++++++++++++++++++
> sound/soc/tegra/tegra210_ahub.h | 125 ++++++++
> 4 files changed, 788 insertions(+)
> create mode 100644 sound/soc/tegra/tegra210_ahub.c
> create mode 100644 sound/soc/tegra/tegra210_ahub.h
Aside from Randy's comment ...
Reviewed-by: Jon Hunter <jonathanh@xxxxxxxxxx>