Re: [PATCH 0/7] proc: Dentry flushing without proc_mnt
From: Al Viro
Date: Thu Feb 20 2020 - 18:08:06 EST
On Thu, Feb 20, 2020 at 03:02:22PM -0800, Linus Torvalds wrote:
> On Thu, Feb 20, 2020 at 12:48 PM Eric W. Biederman
> <ebiederm@xxxxxxxxxxxx> wrote:
> > Linus, does this approach look like something you can stand?
> A couple of worries, although one of them seem to have already been
> resolved by Al.
> I think the real gatekeeper should be Al in general. But other than
> the small comments I had, I think this might work just fine.
I'll need to finish RTFS there; I have initially misread that patch,
actually - Eric _is_ using that thing both for those directories
and for sysctl inodes. And the prototype for that machinery (the
one he'd pulled from proc_sysctl.c) is playing with pinning superblocks
way too much; for per-pid directories that's not an issue, but
for sysctl table removal you are very likely to hit a bunch of
evictees on the same superblock...