Re: [PATCH v2 6/8] bootconfig: Overwrite value on same key by default
From: Masami Hiramatsu
Date: Fri Feb 21 2020 - 01:33:12 EST
On Thu, 20 Feb 2020 21:56:18 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Fri, 21 Feb 2020 09:21:01 +0900
> Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> > On Thu, 20 Feb 2020 12:16:41 -0500
> > Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > > On Thu, 20 Feb 2020 21:19:22 +0900
> > > Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> > >
> > > > Currently, bootconfig does not overwrite existing value
> > > > on same key, but add new value to the tail of an array.
> > > > But this looks a bit confusing because similar syntax
> > > > configuration always overwrite the value by default.
> > >
> > > Should we even allow this case? Or at the very least, some output
> > > should be made that a value is being overwritten.
> > Both are OK, but I like just making it error. At this moment,
> > the bootconfig tool writes user-given bootconfig file to
> > initrd (not reformat it). This means if user ignores the warning
> > from bootconfig tool, they will see same warning on dmesg again.
> OK, so you will be updating this patch?
> FYI, I pulled in patches 1-3,5 and 8. I dropped patch 4, and wanted
> feedback from you on patch 6, and patch 7 depended on 6.
> Feel free to update patch 6 and 7 on top of my git tree branch
OK, I'll send update soon.
> -- Steve
Masami Hiramatsu <mhiramat@xxxxxxxxxx>