Re: [PATCH 1/1] efi/capsule-loader: superfluous assignment

[Ard Biesheuvel]

On Sun, 23 Feb 2020 at 21:54, Heinrich Schuchardt <xypron.glpk@xxxxxx> wrote:
>
> In efi_capsule_write() the value 0 assigned to ret is never used.
>
> Identified with cppcheck.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@xxxxxx>

Queued in efi/next, thanks

> ---
>  drivers/firmware/efi/capsule-loader.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/capsule-loader.c b/drivers/firmware/efi/capsule-loader.c
> index d3067cbd5114..4dde8edd53b6 100644
> --- a/drivers/firmware/efi/capsule-loader.c
> +++ b/drivers/firmware/efi/capsule-loader.c
> @@ -168,7 +168,7 @@ static ssize_t efi_capsule_submit_update(struct capsule_info *cap_info)
>  static ssize_t efi_capsule_write(struct file *file, const char __user *buff,
>                                  size_t count, loff_t *offp)
>  {
> -       int ret = 0;
> +       int ret;
>         struct capsule_info *cap_info = file->private_data;
>         struct page *page;
>         void *kbuff = NULL;
> --
> 2.25.0
>