Re: [PATCH v2 4/9] arm64: dts: librem5-devkit: allow modem to wake the system from suspend

[Shawn Guo]

On Tue, Feb 18, 2020 at 09:49:37AM +0100, Martin Kepplinger wrote:
> From: "Angus Ainslie (Purism)" <angus@xxxxxxxx>
> 
> Connect the WoWWAN signal to a gpio key to wake up the system from suspend.
> 
> Signed-off-by: Angus Ainslie (Purism) <angus@xxxxxxxx>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@xxxxxxx>
> ---
>  .../arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index ec12477d925d..9c81b07f43f3 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -55,6 +55,15 @@
>  			wakeup-source;
>  			linux,code = <KEY_HP>;
>  		};
> +
> +		wwan_wake {

We prefer to use hyphen over underscore in node name.

Shawn

> +			label = "WWAN_WAKE";
> +			gpios = <&gpio3 8 GPIO_ACTIVE_LOW>;
> +			interrupt-parent = <&gpio3>;
> +			interrupts = <8 GPIO_ACTIVE_LOW>;
> +			wakeup-source;
> +			linux,code = <KEY_PHONE>;
> +		};
>  	};
>  
>  	leds {
> @@ -574,6 +583,7 @@
>  			MX8MQ_IOMUXC_SAI2_RXFS_GPIO4_IO21	0x16
>  			MX8MQ_IOMUXC_SAI2_RXC_GPIO4_IO22	0x16
>  			MX8MQ_IOMUXC_SAI5_RXC_GPIO3_IO20	0x180  /* HP_DET */
> +			MX8MQ_IOMUXC_NAND_DATA02_GPIO3_IO8	0x80   /* nWoWWAN */
>  		>;
>  	};
>  
> -- 
> 2.20.1
>