Re: [PATCH 1/3] regulator: max14577: Add proper dt-compatible strings

From: Marek Szyprowski
Date: Mon Feb 24 2020 - 09:08:10 EST


Hi Mark,

On 21.02.2020 18:13, Mark Brown wrote:
> On Fri, Feb 21, 2020 at 02:23:57PM +0100, Marek Szyprowski wrote:
>> On 21.02.2020 13:38, Mark Brown wrote:
>>> We could just remove the compatible strings from the binding
>>> documentation, they won't do any harm if we don't use them.
>> Frankly I have no strong opinion on this. I've just wanted to fix the
>> broken autoloading of the drivers compiled as modules.
> Shouldn't adding the relevant module table for the platform devices work
> just as well for that? Possibly also deleting the of_compatible bits in
> the MFD as well, ISTR that's needed to make the platform device work.

Right. This will work too. MFD cells will match to their drivers by the
name and modalias strings will be correct. The question is which
approach is preffered? Krzysztof? I've checked other mfd drivers, but I
cannot find any pattern in this area.

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland