Re: [PATCH] net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed

From: Nicolas Saenz Julienne
Date: Mon Feb 24 2020 - 11:30:12 EST


On Mon, 2020-02-24 at 18:28 +0200, Leon Romanovsky wrote:
> On Mon, Feb 24, 2020 at 04:36:09PM +0100, Nicolas Saenz Julienne wrote:
> > Outdated Raspberry Pi 4 firmware might configure the external PHY as
> > rgmii although the kernel currently sets it as rgmii-rxid. This makes
> > connections unreliable as ID_MODE_DIS is left enabled. To avoid this,
> > explicitly clear that bit whenever we don't need it.
> >
> > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx>
> > Fixes: da38802211cc ("net: bcmgenet: Add RGMII_RXID support")
>
> The expectation is that Fixes line comes before SOB line.

Ouch, sorry for that.

I'll edit that on v2.

Regards,
Nicolas

Attachment: signature.asc
Description: This is a digitally signed message part