Re: [PATCH nf] netfilter: ensure rcu_read_lock() in ipv4_find_option()

From: Matteo Croce
Date: Mon Feb 24 2020 - 14:43:12 EST


On Mon, Feb 24, 2020 at 8:12 PM Florian Westphal <fw@xxxxxxxxx> wrote:
>
> Matteo Croce <mcroce@xxxxxxxxxx> wrote:
> > As in commit c543cb4a5f07 ("ipv4: ensure rcu_read_lock() in ipv4_link_failure()")
> > and commit 3e72dfdf8227 ("ipv4: ensure rcu_read_lock() in cipso_v4_error()"),
> > __ip_options_compile() must be called under rcu protection.
>
> This is not needed, all netfilter hooks run with rcu_read_lock held.
>

Ok, so let's drop it, thanks.

--
Matteo Croce
per aspera ad upstream