Re: [PATCH v2 16/18] clocksource: Replace setup_irq() by request_irq()

From: kbuild test robot
Date: Mon Feb 24 2020 - 21:53:32 EST

Hi afzal,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/timers/core]
[also build test ERROR on arm-soc/for-next powerpc/next linus/master v5.6-rc3 next-20200221]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/afzal-mohammed/genirq-Remove-setup_irq/20200224-085537
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 5fb1c2a5bbf79ccca8d17cf97f66085be5808027
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=sparc

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

drivers/clocksource/timer-prima2.c: In function 'sirfsoc_prima2_timer_init':
>> drivers/clocksource/timer-prima2.c:213:2: error: 'sirfsoc_timer_irq' undeclared (first use in this function); did you mean 'sirfsoc_timer_read'?
sirfsoc_timer_irq.irq = irq_of_parse_and_map(np, 0);
^~~~~~~~~~~~~~~~~
sirfsoc_timer_read
drivers/clocksource/timer-prima2.c:213:2: note: each undeclared identifier is reported only once for each function it appears in

vim +213 drivers/clocksource/timer-prima2.c

02c981c07bc95a arch/arm/mach-prima2/timer.c Binghua Duan 2011-07-08 180
02c981c07bc95a arch/arm/mach-prima2/timer.c Binghua Duan 2011-07-08 181 /* initialize the kernel jiffy timer source */
de23484dd50829 drivers/clocksource/timer-prima2.c Daniel Lezcano 2016-06-06 182 static int __init sirfsoc_prima2_timer_init(struct device_node *np)
02c981c07bc95a arch/arm/mach-prima2/timer.c Binghua Duan 2011-07-08 183 {
02c981c07bc95a arch/arm/mach-prima2/timer.c Binghua Duan 2011-07-08 184 unsigned long rate;
198678b0b8533e arch/arm/mach-prima2/timer.c Binghua Duan 2012-08-20 185 struct clk *clk;
de23484dd50829 drivers/clocksource/timer-prima2.c Daniel Lezcano 2016-06-06 186 int ret;
198678b0b8533e arch/arm/mach-prima2/timer.c Binghua Duan 2012-08-20 187
c7cff54d5926e3 drivers/clocksource/timer-prima2.c Zhiwu Song 2014-05-05 188 clk = of_clk_get(np, 0);
de23484dd50829 drivers/clocksource/timer-prima2.c Daniel Lezcano 2016-06-06 189 if (IS_ERR(clk)) {
ac9ce6d1a0cc29 drivers/clocksource/timer-prima2.c RafaÅ MiÅecki 2017-03-09 190 pr_err("Failed to get clock\n");
de23484dd50829 drivers/clocksource/timer-prima2.c Daniel Lezcano 2016-06-06 191 return PTR_ERR(clk);
de23484dd50829 drivers/clocksource/timer-prima2.c Daniel Lezcano 2016-06-06 192 }
38941522ecbd21 drivers/clocksource/timer-prima2.c Zhiwu Song 2014-07-03 193
de23484dd50829 drivers/clocksource/timer-prima2.c Daniel Lezcano 2016-06-06 194 ret = clk_prepare_enable(clk);
de23484dd50829 drivers/clocksource/timer-prima2.c Daniel Lezcano 2016-06-06 195 if (ret) {
ac9ce6d1a0cc29 drivers/clocksource/timer-prima2.c RafaÅ MiÅecki 2017-03-09 196 pr_err("Failed to enable clock\n");
de23484dd50829 drivers/clocksource/timer-prima2.c Daniel Lezcano 2016-06-06 197 return ret;
de23484dd50829 drivers/clocksource/timer-prima2.c Daniel Lezcano 2016-06-06 198 }
38941522ecbd21 drivers/clocksource/timer-prima2.c Zhiwu Song 2014-07-03 199
02c981c07bc95a arch/arm/mach-prima2/timer.c Binghua Duan 2011-07-08 200 rate = clk_get_rate(clk);
02c981c07bc95a arch/arm/mach-prima2/timer.c Binghua Duan 2011-07-08 201
de23484dd50829 drivers/clocksource/timer-prima2.c Daniel Lezcano 2016-06-06 202 if (rate < PRIMA2_CLOCK_FREQ || rate % PRIMA2_CLOCK_FREQ) {
ac9ce6d1a0cc29 drivers/clocksource/timer-prima2.c RafaÅ MiÅecki 2017-03-09 203 pr_err("Invalid clock rate\n");
de23484dd50829 drivers/clocksource/timer-prima2.c Daniel Lezcano 2016-06-06 204 return -EINVAL;
de23484dd50829 drivers/clocksource/timer-prima2.c Daniel Lezcano 2016-06-06 205 }
02c981c07bc95a arch/arm/mach-prima2/timer.c Binghua Duan 2011-07-08 206
275786b71d42bb drivers/clocksource/timer-prima2.c Arnd Bergmann 2013-03-19 207 sirfsoc_timer_base = of_iomap(np, 0);
de23484dd50829 drivers/clocksource/timer-prima2.c Daniel Lezcano 2016-06-06 208 if (!sirfsoc_timer_base) {
de23484dd50829 drivers/clocksource/timer-prima2.c Daniel Lezcano 2016-06-06 209 pr_err("unable to map timer cpu registers\n");
de23484dd50829 drivers/clocksource/timer-prima2.c Daniel Lezcano 2016-06-06 210 return -ENXIO;
de23484dd50829 drivers/clocksource/timer-prima2.c Daniel Lezcano 2016-06-06 211 }
275786b71d42bb drivers/clocksource/timer-prima2.c Arnd Bergmann 2013-03-19 212
275786b71d42bb drivers/clocksource/timer-prima2.c Arnd Bergmann 2013-03-19 @213 sirfsoc_timer_irq.irq = irq_of_parse_and_map(np, 0);

:::::: The code at line 213 was first introduced by commit
:::::: 275786b71d42bb54c03c15197128d7cb05d4dd8b ARM: sirf: use clocksource_of infrastructure

:::::: TO: Arnd Bergmann <arnd@xxxxxxxx>
:::::: CC: Arnd Bergmann <arnd@xxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip