Re: [RFC PATCH v3 5/8] regulator: use linear_ranges helper

From: Vaittinen, Matti
Date: Tue Feb 25 2020 - 01:23:40 EST


Hello Mark,

On Mon, 2020-02-24 at 11:57 +0000, Mark Brown wrote:
> On Thu, Feb 20, 2020 at 09:36:38AM +0200, Matti Vaittinen wrote:
> > Change the regulator helpers to use common linear_ranges code.
>
> This needs to be squashed in with the previous commit to avoid build
> breaks.

I don't think so.

Only change required on individual regulator drivers should be renaming
the struct regulator_linear_range to linear_range. Rest of the changes
should be internal to regulator framework, right?

Even the naming change of the linear_range struct members should not be
visible to these drivers as they use the initializer macro for setting
the values. I must admit I didn't compile _all_ the regulator drivers
when I tested this though. I will try compiling at least most of the
regulator drivers for next version though. And I think the feedback for
this series has been mostly positive so I'll also drop the RFC for it.

Best Regards
Matti Vaittinen