Re: [PATCH] dma: imx-sdma: Fix the event id check to include RX event for UART6

[Schrempf Frieder]

Hi Fabio,

On 24.02.20 19:43, Fabio Estevam wrote:
> Hi Frieder,
> 
> On Mon, Feb 24, 2020 at 2:22 PM Schrempf Frieder
> <frieder.schrempf@xxxxxxxxxx> wrote:
>>
>> From: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>
>>
>> On i.MX6 the DMA event for the RX channel of UART6 is '0'. To fix
> 
> I would suggest being a bit more specific than saying i.MX6.
> 
> I see UART6 is present on i.MX6UL/i.MX6SX, but not on i.MX6Q/i.MX6DL,
> so it would be better to specify it in the commit log.
> 
> imx6ul.dtsi does not have dma nodes under uart6, so I guess you fixed
> it for imx6sx.

Sounds reasonable. I will change the commit message to refer to 
i.MX6UL/ULL/SX.

Actually one of our customers has a dts for i.MX6UL, that enables the 
DMA for UART6. The DMA not being enabled in imx6ul.dtsi doesn't mean no 
one is using it. Actually I have no idea why it's enabled by default for 
i.MX6SX and disabled by default for i.MX6UL.

Thanks,
Frieder

> 
>> the broken DMA support for UART6, we change the check for event_id0
>> to include '0' as a valid id.
>>
>> Fixes: 1ec1e82f2510 ("dmaengine: Add Freescale i.MX SDMA support")
>> Cc: stable@xxxxxxxxxxxxxxx
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>
> 
> Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>
>