Re: [PATCH v4 9/9] power: supply: Support ROHM bd99954 charger

From: Vaittinen, Matti
Date: Wed Feb 26 2020 - 02:58:58 EST


Hello Randy,

On Tue, 2020-02-25 at 08:21 -0800, Randy Dunlap wrote:
> On 2/25/20 12:55 AM, Matti Vaittinen wrote:
> > diff --git a/drivers/power/supply/Kconfig
> > b/drivers/power/supply/Kconfig
> > index 8781c674ed07..0b3bad6fc736 100644
> > --- a/drivers/power/supply/Kconfig
> > +++ b/drivers/power/supply/Kconfig
> > @@ -702,6 +702,16 @@ config CHARGER_BD70528
> > information and altering charger configurations from charger
> > block of the ROHM BD70528 Power Management IC.
> >
>
> Hi,
>
> > +config CHARGER_BD99954
> > + tristate "ROHM bd99954 charger driver"
> > + depends on I2C
> > + select LINEAR_RANGES
> > + default n
>
> Drop the "default n", since it is already the default.
>
> > + help
> > + Say Y here to enable support for getting battery and charger
> > + information and altering charger configurations from the ROHM
> > + BD99954 charger IC.
>
> Please indent the 3 lines of help text with one additional space (2
> total).
> See Documentation/process/coding-style.rst:
>
> 10) Kconfig configuration files
> -------------------------------
>
> For all of the Kconfig* configuration files throughout the source
> tree,
> the indentation is somewhat different. Lines under a ``config``
> definition
> are indented with one tab, while help text is indented an additional
> two
> spaces. Example::
>
> config AUDIT
> bool "Auditing support"
> depends on NET
> help
> Enable auditing infrastructure that can be used with another
> kernel subsystem, such as SELinux (which requires this for
> logging of avc messages output). Does not do system-call
> auditing without CONFIG_AUDITSYSCALL.
>
> > +
> > config CHARGER_WILCO
> > tristate "Wilco EC based charger for ChromeOS"
> > depends on WILCO_EC
>
> thanks.

Thanks again for the review. I'll fix these for the next version :)

Br,
Matti Vaittinen