Re: [PATCH V4 00/13] Enable per-file/per-directory DAX operations V4

From: Ira Weiny
Date: Wed Feb 26 2020 - 21:44:00 EST


On Wed, Feb 26, 2020 at 05:48:38PM -0500, Jeff Moyer wrote:
> Hi, Ira,
>
> ira.weiny@xxxxxxxxx writes:
>
> > From: Ira Weiny <ira.weiny@xxxxxxxxx>
> >
> > https://github.com/weiny2/linux-kernel/pull/new/dax-file-state-change-v4
> >
> > Changes from V3:
> > https://lore.kernel.org/lkml/20200208193445.27421-1-ira.weiny@xxxxxxxxx/
> >
> > * Remove global locking... :-D
> > * put back per inode locking and remove pre-mature optimizations
> > * Fix issues with Directories having IS_DAX() set
> > * Fix kernel crash issues reported by Jeff
> > * Add some clean up patches
> > * Consolidate diflags to iflags functions
> > * Update/add documentation
> > * Reorder/rename patches quite a bit
>
> I left out patches 1 and 2, but applied the rest and tested. This
> passes xfs tests in the following configurations:
> 1) MKFS_OPTIONS="-m reflink=0" MOUNT_OPTIONS="-o dax"
> 2) MKFS_OPTIONS="-m reflink=0"
> but with the added configuration step of setting the dax attribute on
> the mounted test directory.
>
> I also tested to ensure that reflink fails when a file has the dax
> attribute set. I've got more testing to do, but figured I'd at least
> let you know I've been looking at it.

Thank you!

I need to update my xfstest which is specific to this as well... I'll get to
that tomorrow and send an updated patch...

Thanks!
Ira

>
> Thanks!
> Jeff
>