Re: [PATCH v2 2/3] perf vendor events amd: add Zen2 events

From: Vijay Thakkar
Date: Fri Feb 28 2020 - 12:34:24 EST


> > + {
> > + "EventName": "de_dis_dispatch_token_stalls0.sc_agu_dispatch_stall",
> > + "EventCode": "0xaf",
> > + "BriefDescription": "SC AGU dispatch stall.",
> > + "PublicDescription": "Cycles where a dispatch group is valid but does not get dispatched due to a token stall. RETIRE Tokens unavailable.",
> > + "UMask": "0x80"
> > + },
>
> All the above Public descriptions have "RETIRE Tokens unavailable."
> yet their BriefDescriptions are different. Please fix.

Just noticed that this one is not present at all in PPR 56176 Rev 3.06 - Jul
17, 2019 and that the umasks for the rest of the sub-counters in PMC0xAF
are right shifted by one when compared to those in Zen1. As a result,
the previous counter at umask 0x1 is no longer present.

I will update this counter to reflect what is documented in model 71h PPR 56176 Rev
3.06 - Jul 17, 2019.

-Vijay