Re: [PATCH] gpiolib: fix bitmap operations related to line event watching

From: Bartosz Golaszewski
Date: Sat Feb 29 2020 - 08:43:21 EST


sob., 29 lut 2020 o 00:20 Linus Walleij <linus.walleij@xxxxxxxxxx> napisaÅ(a):
>
> On Wed, Feb 26, 2020 at 2:53 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
>
> > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> >
> > When operating on the bits of watched_lines bitmap, we're using
> > desc_to_gpio() which returns the GPIO number from the global numberspace.
> > This leads to all sorts of memory corruptions and invalid behavior. We
> > should switch to using gpio_chip_hwgpio() instead.
> >
> > Fixes: 51c1064e82e7 ("gpiolib: add new ioctl() for monitoring changes in line info")
> > Reported-by: Kent Gibson <warthog618@xxxxxxxxx>
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
>
> This looks good but where should it be applied?
> It fails to apply to my devel branch where this lives.
>
> Yours,
> Linus Walleij

This depends on Kent's other patch. I'll send you a PR.

Bart