Re: [PATCH net-next 0/2] net: phy: mscc: support LOS active low

[David Miller]

From: Antoine Tenart <antoine.tenart@xxxxxxxxxxx>
Date: Thu, 27 Feb 2020 17:10:10 +0100

> Hello Andrew,
> 
> On Thu, Feb 27, 2020 at 04:54:40PM +0100, Andrew Lunn wrote:
>> On Thu, Feb 27, 2020 at 04:40:31PM +0100, Antoine Tenart wrote:
>> > 
>> > This series adds a device tree property for the VSC8584 PHY family to
>> > describe the LOS pin connected to the PHY as being active low. This new
>> > property is then used in the MSCC PHY driver.
>> 
>> I think i'm missing the big picture.
>> 
>> Is this for when an SFP is connected directly to the PHY? The SFP
>> output LOS, indicating loss of received fibre/copper signal, is active
>> low?
> 
> Yes, the SFP cage can be connected directly to the PHY, and the SFP LOS
> signal is active low (there's a pull-up on the LOS line).
> 
> Also, I realized I send this series before my other patches adding
> support for fibre mode on this PHY, so it may make more sense to send
> this one after.

Please do so, I'll mark these as deferred in patchwork.