Re: [PATCH v2 0/3] virtio-net: introduce features defined in the spec

From: Yuri Benditovich
Date: Sun Mar 01 2020 - 07:47:59 EST


On Sun, Mar 1, 2020 at 1:32 PM Michael S. Tsirkin <mst@xxxxxxxxxx> wrote:
>
> On Sun, Mar 01, 2020 at 01:07:30PM +0200, Yuri Benditovich wrote:
> > This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT,
> > VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT.
> >
> > Changes from v1:
> > __virtio -> __le
> > maximal -> maximum
> > minor style fixes
>
>
> Looks good to me - sent a bit of consmetics.
>
> But as any virtio UAPI change, please CC virtio-dev as virtio TC maintains the
> interface. Thanks!

Probably 'virtio-dev' should be added to maintainers file.

>
> > Yuri Benditovich (3):
> > virtio-net: Introduce extended RSC feature
> > virtio-net: Introduce RSS receive steering feature
> > virtio-net: Introduce hash report feature
> >
> > include/uapi/linux/virtio_net.h | 90 +++++++++++++++++++++++++++++++--
> > 1 file changed, 86 insertions(+), 4 deletions(-)
> >
> > --
> > 2.17.1
>