Re: [PATCH V2] thermal: imx_thermal: Use __maybe_unused instead of CONFIG_PM_SLEEP

From: Daniel Lezcano
Date: Mon Mar 02 2020 - 03:54:40 EST


On 02/03/2020 09:26, Anson Huang wrote:
> Hi, Uwe
>
>
>> Subject: Re: [PATCH V2] thermal: imx_thermal: Use __maybe_unused instead
>> of CONFIG_PM_SLEEP
>>
>> On Mon, Mar 02, 2020 at 03:50:10PM +0800, Anson Huang wrote:
>>> Use __maybe_unused for power management related functions instead of
>>> #if CONFIG_PM_SLEEP to simplify the code.
>>>
>>> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
>>> Reviewed-by: Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>
>>
>> IMHO translating my "otherwise looks fine" in a "Reviewed-by" is a bit bold.
>> Please don't assume this.
>
> OK, will keep it in mind next time, thanks.

When applying a patch, now we add the link to the lkml archive
automatically. I can't apply this patch if the Reviewed-by is not accepted.

Or the Reviewed-by tag is confirmed or a V3 without the Reviewed-by must
be resent.


--
<http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog