Re: [PATCH 2/3] ARM: dts: stm32: add STM32MP1-based Linux Automation MC-1 board

[Alexandre Torgue]

Hi Lucas

On 3/2/20 11:18 AM, Lucas Stach wrote:
> On Mo, 2020-03-02 at 11:06 +0100, Alexandre Torgue wrote:
> > Hi Ahmad
> >
> > Thanks for adding a new STM32 board. Some minor comments.
> >
> > On 2/26/20 3:38 PM, Ahmad Fatoum wrote:
> > > The Linux Automation MC-1 is a SBC built around the Octavo Systems
> > > OSD32MP15x SiP. The SiP features up to 1 GB DDR3 RAM, EEPROM and
> > > a PMIC. The board has eMMC and a SD slot for storage and GbE
> > > for both connectivity and power.
> > >
> > > Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx
> > > ---
> [...]
> > > +
> > > +&gpu {
> > > +	status = "okay";
> > > +};
>
> This question is more to the ST guys than this specific DT: Why is the
> GPU marked as disabled in the SoC dtsi file? This device is always
> present on the SoC and AFAICS there are no board level dependencies, so
> there is no reason to have it disabled by default, right? Removing the
> status property from the dtsi would remove the need for this override
> on the board DT.

You are right. With new stm32 device tree diversity, it makes no longer 
sens to disable GPU node in stm32mp157 dtsi file. Indeed, we use now 
dedicated files for each SoC (stm32mp151 / stm32mp153 /stm32mp157).

Ahmad, can you add this modification in your series please ?

regards
Alex


> Regards,
> Lucas