Re: [PATCH 4/4] video: fbdev: remove set but not used variable 'bytpp'

From: Bartlomiej Zolnierkiewicz
Date: Mon Mar 02 2020 - 10:42:40 EST



On 1/19/20 1:17 PM, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/video/fbdev/aty/radeon_base.c: In function
> âradeonfb_set_parâ:
> drivers/video/fbdev/aty/radeon_base.c:1660:32: warning:
> variable âbytppâ set but not used [-Wunused-but-set-variable]
>
> It is never used, and so can be removed.
>
> Signed-off-by: yu kuai <yukuai3@xxxxxxxxxx>

Patch queued for v5.7, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
> drivers/video/fbdev/aty/radeon_base.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c
> index 7d2ee889ffcd..22b3ee4f2ffa 100644
> --- a/drivers/video/fbdev/aty/radeon_base.c
> +++ b/drivers/video/fbdev/aty/radeon_base.c
> @@ -1657,7 +1657,7 @@ static int radeonfb_set_par(struct fb_info *info)
> int i, freq;
> int format = 0;
> int nopllcalc = 0;
> - int hsync_start, hsync_fudge, bytpp, hsync_wid, vsync_wid;
> + int hsync_start, hsync_fudge, hsync_wid, vsync_wid;
> int primary_mon = PRIMARY_MONITOR(rinfo);
> int depth = var_to_depth(mode);
> int use_rmx = 0;
> @@ -1731,7 +1731,6 @@ static int radeonfb_set_par(struct fb_info *info)
> vsync_wid = 0x1f;
>
> format = radeon_get_dstbpp(depth);
> - bytpp = mode->bits_per_pixel >> 3;
>
> if ((primary_mon == MT_DFP) || (primary_mon == MT_LCD))
> hsync_fudge = hsync_fudge_fp[format-1];
>