Re: [PATCH v3] of: overlay: log the error cause on resolver failure

From: Geert Uytterhoeven
Date: Mon Mar 02 2020 - 11:06:34 EST


On Fri, Feb 28, 2020 at 9:40 AM Luca Ceresoli <luca@xxxxxxxxxxxxxxxx> wrote:
> When a DT overlay has a node label that is not present in the live
> devicetree symbols table, this error is printed:
>
> OF: resolver: overlay phandle fixup failed: -22
> create_overlay: Failed to create overlay (err=-22)
>
> which does not help much in finding the node label that caused the problem
> and fix the overlay source.
>
> Add an error message with the name of the node label that caused the
> error. The new output is:
>
> OF: resolver: node label 'gpio9' not found in live devicetree symbols table
> OF: resolver: overlay phandle fixup failed: -22
> create_overlay: Failed to create overlay (err=-22)
>
> Signed-off-by: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds