[PATCH] coresight: cti: Remove unnecessary NULL check in cti_sig_type_name

From: Nathan Chancellor
Date: Mon Mar 02 2020 - 16:34:25 EST


Clang warns:

drivers/hwtracing/coresight/coresight-cti-sysfs.c:948:11: warning:
address of array 'grp->sig_types' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (grp->sig_types) {
~~ ~~~~~^~~~~~~~~
1 warning generated.

sig_types is at the end of a struct so it cannot be NULL.

Fixes: 85b6684eab65 ("coresight: cti: Add connection information to sysfs")
Link: https://github.com/ClangBuiltLinux/linux/issues/914
Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
---
drivers/hwtracing/coresight/coresight-cti-sysfs.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/hwtracing/coresight/coresight-cti-sysfs.c b/drivers/hwtracing/coresight/coresight-cti-sysfs.c
index abb7f492c2cb..214d6552b494 100644
--- a/drivers/hwtracing/coresight/coresight-cti-sysfs.c
+++ b/drivers/hwtracing/coresight/coresight-cti-sysfs.c
@@ -945,10 +945,8 @@ cti_sig_type_name(struct cti_trig_con *con, int used_count, bool in)
int idx = 0;
struct cti_trig_grp *grp = in ? con->con_in : con->con_out;

- if (grp->sig_types) {
- if (used_count < grp->nr_sigs)
- idx = grp->sig_types[used_count];
- }
+ if (used_count < grp->nr_sigs)
+ idx = grp->sig_types[used_count];
return sig_type_names[idx];
}

--
2.25.1