RE: [PATCH 2/2] thermal: Remove COMPILE_TEST for IMX_SC_THERMAL

From: Anson Huang
Date: Tue Mar 03 2020 - 04:19:34 EST


Hi, Amit

> Subject: Re: [PATCH 2/2] thermal: Remove COMPILE_TEST for
> IMX_SC_THERMAL
>
> On Tue, Mar 3, 2020 at 1:40 PM Anson Huang <Anson.Huang@xxxxxxx>
> wrote:
> >
> > i.MX SCU thermal driver depends on IMX_SCU which does NOT have
> > COMPILE_TEST enabled, so need to remove COMPILE_TEST for i.MX SCU
> > thermal as well.
>
> Wouldn't a better solution be to add COMPILE_TEST to IMX_SCU to improve
> compile coverage?

It is a good idea, but I think since there are many i.MX8 modules driver also depend on IMX_SCU,
It would be better to cut another patch set to enable COMPILE_TEST for IMX_SCU as well
as all those modules that depend on it, then the compile coverage will cover all i.MX8 modules
depend on IMX_SCU.

Thanks,
Anson