Re: [PATCH v1] net: dsa: sja1105: add 100baseT1_Full support

[Vladimir Oltean]

On Tue, 3 Mar 2020 at 09:44, Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:
>
> Validate 100baseT1_Full to make this driver work with TJA1102 PHY.
>
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> ---

I was expecting this patch sooner or later.

Acked-by: Vladimir Oltean <olteanv@xxxxxxxxx>

I should take this opportunity and express the fact that it is strange
for MAC drivers to have to sign off all possible copper and fiber
media types in their .phylink_validate method. Sooner or later
somebody is going to want to add 1000Base-T1 too. I don't think it is
going to scale very well. Russell, with your plan to make MAC drivers
just populate a bitmap of phy_modes (MII side), is it also going to
get rid of media side validation?

>  drivers/net/dsa/sja1105/sja1105_main.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c
> index 34544b1c30dc..7b5a80ba12bd 100644
> --- a/drivers/net/dsa/sja1105/sja1105_main.c
> +++ b/drivers/net/dsa/sja1105/sja1105_main.c
> @@ -866,6 +866,7 @@ static void sja1105_phylink_validate(struct dsa_switch *ds, int port,
>         phylink_set(mask, MII);
>         phylink_set(mask, 10baseT_Full);
>         phylink_set(mask, 100baseT_Full);
> +       phylink_set(mask, 100baseT1_Full);
>         if (mii->xmii_mode[port] == XMII_MODE_RGMII)
>                 phylink_set(mask, 1000baseT_Full);
>
> --
> 2.25.0
>

Regards,
-Vladimir