Re: [PATCH] ASoC: Fix SND_SOC_ALL_CODECS imply ac97 fallout

From: Guenter Roeck
Date: Tue Mar 03 2020 - 09:34:49 EST


On Mon, Feb 24, 2020 at 12:25:37PM +0100, Geert Uytterhoeven wrote:
> On i386 randconfig:
>
> sound/soc/codecs/wm9705.o: In function `wm9705_soc_resume':
> wm9705.c:(.text+0x128): undefined reference to `snd_ac97_reset'
> sound/soc/codecs/wm9712.o: In function `wm9712_soc_resume':
> wm9712.c:(.text+0x2d1): undefined reference to `snd_ac97_reset'
> sound/soc/codecs/wm9713.o: In function `wm9713_soc_resume':
> wm9713.c:(.text+0x820): undefined reference to `snd_ac97_reset'
>
> Fix this by adding the missing dependencies on SND_SOC_AC97_BUS.
>

With this patch applied, arm:pxa_defconfig reports a variety of unmet
SND_SOC dependencies, and it fails to build.

ERROR: "snd_ac97_reset" [sound/soc/codecs/snd-soc-wm9713.ko] undefined!
ERROR: "snd_ac97_reset" [sound/soc/codecs/snd-soc-wm9712.ko] undefined!
ERROR: "snd_ac97_reset" [sound/soc/codecs/snd-soc-wm9705.ko] undefined!

Reverting this patch fixes the problem.

Guenter