Re: [PATCH] usb: phy: tegra: Include proper GPIO consumer header to fix compile testing

[Dmitry Osipenko]

03.03.2020 14:29, Krzysztof Kozlowski ÐÐÑÐÑ:
> The driver uses only GPIO Descriptor Consumer Interface so include
> proper header.  This fixes compile test failures (e.g. on i386):
> 
>     drivers/usb/phy/phy-tegra-usb.c: In function âulpi_phy_power_onâ:
>     drivers/usb/phy/phy-tegra-usb.c:695:2: error:
>         implicit declaration of function âgpiod_set_value_cansleepâ [-Werror=implicit-function-declaration]
>     drivers/usb/phy/phy-tegra-usb.c: In function âtegra_usb_phy_probeâ:
>     drivers/usb/phy/phy-tegra-usb.c:1167:11: error:
>         implicit declaration of function âdevm_gpiod_get_from_of_nodeâ [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> ---
>  drivers/usb/phy/phy-tegra-usb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
> index 6153cc35aba0..cffe2aced488 100644
> --- a/drivers/usb/phy/phy-tegra-usb.c
> +++ b/drivers/usb/phy/phy-tegra-usb.c
> @@ -12,12 +12,11 @@
>  #include <linux/delay.h>
>  #include <linux/err.h>
>  #include <linux/export.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
>  #include <linux/iopoll.h>
>  #include <linux/module.h>
>  #include <linux/of.h>
>  #include <linux/of_device.h>
> -#include <linux/of_gpio.h>
>  #include <linux/platform_device.h>
>  #include <linux/resource.h>
>  #include <linux/slab.h>
> 

Thanks,

Reviewed-by: Dmitry Osipenko <digetx@xxxxxxxxx>