Re: [PATCH v3 2/2] arm64: dts: rockchip: Add initial support for Pinebook Pro

[Johan Jonker]

Hi,

Add more reg = <..>

On 3/3/20 4:37 PM, Johan Jonker wrote:
> Hi Tobias,
> 
> Some minor style issues.
> This dts file contains a partition node.
> Question for the maintainers (Heiko?):
> Should that partition be included or not?

[..]

>> +&i2c4 {
>> +	i2c-scl-falling-time-ns = <20>;
>> +	i2c-scl-rising-time-ns = <600>;
>> +	status = "okay";
>> +
>> +	fusb0: fusb30x@22 {
>> +		compatible = "fcs,fusb302";
>> +		reg = <0x22>;
>> +		fcs,int_n = <&gpio1 RK_PA2 GPIO_ACTIVE_HIGH>;
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&fusb0_int_gpio>;
> 
>> +		status = "okay";
> 
> Remove or else status below.
> New nodes are already okay I think.
> If insure check compiled flat dts output to see if it is still there.
> 
>> +		vbus-supply = <&vbus_typec>;
>> +
>> +		connector {
>> +			compatible = "usb-c-connector";
>> +			label = "USB-C";
>> +			op-sink-microwatt = <1000000>;
>> +			power-role = "dual";
>> +			sink-pdos =
>> +				<PDO_FIXED(5000, 2500, PDO_FIXED_USB_COMM)>;
>> +			source-pdos =
>> +				<PDO_FIXED(5000, 1400, PDO_FIXED_USB_COMM)>;
>> +			try-power-role = "sink";
>> +
>> +			ports {
>> +				#address-cells = <1>;
>> +				#size-cells = <0>;
>> +
>> +				port@0 {

reg = <0>;

>> +					usbc_hs: endpoint {
>> +						remote-endpoint =
>> +							<&u2phy0_typec_hs>;
>> +					};
>> +				};
>> +
>> +				port@1 {

reg = <1>;

>> +					usbc_ss: endpoint {
>> +						remote-endpoint =
>> +							<&tcphy0_typec_ss>;
>> +					};
>> +				};
>> +
>> +				port@2 {

reg = <2>;

>> +					usbc_dp: endpoint {
>> +						remote-endpoint =
>> +							<&tcphy0_typec_dp>;
>> +					};
>> +				};
>> +			};
>> +		};
>> +	};
>> +};