Re: [PATCH v9 2/7] KVM: VMX: Define CET VMCS fields and #CP flag

From: Sean Christopherson
Date: Tue Mar 03 2020 - 16:42:56 EST


On Fri, Dec 27, 2019 at 10:11:28AM +0800, Yang Weijiang wrote:
> @@ -298,7 +298,8 @@ int x86_emulate_instruction(struct kvm_vcpu *vcpu, unsigned long cr2,
> * In future, applicable XSS state bits can be added here
> * to make them available to KVM and guest.
> */
> -#define KVM_SUPPORTED_XSS 0
> +#define KVM_SUPPORTED_XSS (XFEATURE_MASK_CET_USER \
> + | XFEATURE_MASK_CET_KERNEL)

My preference would be to put the operator on the previous line, though I
realize this diverges from other KVM behavior. I find it much easier to
read With the names aligned.

#define KVM_SUPPORTED_XSS (XFEATURE_MASK_CET_USER | \
XFEATURE_MASK_CET_KERNEL)
>
> extern u64 host_xcr0;
>
> --
> 2.17.2
>