Re: [PATCH net 4/4] dpaa_eth: FMan erratum A050385 workaround

From: David Miller
Date: Tue Mar 03 2020 - 18:54:29 EST


From: Madalin Bucur <madalin.bucur@xxxxxxxxxxx>
Date: Tue, 3 Mar 2020 17:55:39 +0200

> +#define DPAA_FD_DATA_ALIGNMENT ((fman_has_errata_a050385()) ? \

You don't need parenthesis around that fman_has_errata_a050385() call.

> +#define dpaa_bp_size(raw_size) ((SKB_WITH_OVERHEAD(raw_size)) & \

Similar again for SKB_WITH_OVERHEAD()

Also, how often does this errata code trigger on effected platforms and
what is the performance degradation from that? I don't see this analysis
performed anywhere.