Re: [PATCH 2/2] tty:serial:mvebu-uart:fix a wrong return

From: Jiri Slaby
Date: Wed Mar 04 2020 - 05:07:06 EST


On 04. 03. 20, 10:37, åå wrote:
> Â Â ÂI'm very happy for your replay. But I don't understand, in this
> place ,it's function is to judge.You say 'the probe function is expected
> to return a negative value in case of error'ïBut at the top or bottom
> of the code here in mvebu_uart_probe()ïthere are a lot of judgments
> that return negative numbers. How do you explain that?

That's exactly the point. The function should return a negative value
and PTR_ERR already returns a negative.

That is, your patch is correct, but your commit message missed an
explanation.

thanks,
--
js
suse labs