Re: [PATCH v3 2/2] xenbus: req->err should be updated before req->state

From: Julien Grall
Date: Wed Mar 04 2020 - 08:50:55 EST


Hi,

On 03/03/2020 22:14, Dongli Zhang wrote:
This patch adds the barrier to guarantee that req->err is always updated
before req->state.

Otherwise, read_reply() would not return ERR_PTR(req->err) but
req->body, when process_writes()->xb_write() is failed.

Signed-off-by: Dongli Zhang <dongli.zhang@xxxxxxxxxx>

Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

---
Julien Grall