Re: [PATCH v2 3/6] irq/domain: add a new callback to domain ops

From: Marc Zyngier
Date: Sun Mar 08 2020 - 09:51:23 EST


On Tue, 11 Feb 2020 14:12:37 +0100
Bartosz Golaszewski <brgl@xxxxxxxx> wrote:

> From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
>
> Add the remove() callback to irq_domain_ops which can be used to
> automatically dispose of any host data associated with the domain when
> irq_domain_remove() is called.

I have a hard time buying this. Whatever data that is associated to the
domain is already owned known by whoever created the domain the first
place.

Since the expected use case is that whoever created the domain also
destroys it, the caller is already in a position to do its own cleanup,
and we don't need any of this.

So please explain what you are trying to achieve here.

Thanks,

M.
--
Jazz is not dead. It just smells funny...