Re: [PATCH] sched/fair: fix build warning about undefined test_idle_cores()

From: Mel Gorman
Date: Sun Mar 08 2020 - 14:34:56 EST


On Sun, Mar 08, 2020 at 11:53:12PM +0800, qiwuchen55@xxxxxxxxx wrote:
> From: chenqiwu <chenqiwu@xxxxxxxxxx>
>
> The build with arm64's defconfig:
> CONFIG_SCHED_MC=y
> # CONFIG_SCHED_SMT is not set
>
> Trigger the following warning due to test_idle_cores()'s definition
> missing:
> kernel/sched/fair.c:1524:20: warning: ???test_idle_cores??? declared ???static???
> but never defined [-Wunused-function]
>
> Move the CONFIG_SCHED_SMT ifdeffery around test_idle_cores()'s declaration
> to fix it.
>
> Signed-off-by: chenqiwu <chenqiwu@xxxxxxxxxx>

Thanks. A fix has been merged to tip/sched/core as

commit 76c389ab2b5e300698eab87f9d4b7916f14117ba
Author: Valentin Schneider <valentin.schneider@xxxxxxx>
Date: Tue Mar 3 11:02:57 2020 +0000

sched/fair: Fix kernel build warning in test_idle_cores() for !SMT NUMA


--
Mel Gorman
SUSE Labs