RE: [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col parameter

From: Manish Narani
Date: Mon Mar 09 2020 - 04:44:50 EST


Hi,

> -----Original Message-----
> From: Sherry Sun <sherry.sun@xxxxxxx>
> Sent: Friday, February 28, 2020 7:46 AM
> To: bp@xxxxxxxxx; mchehab@xxxxxxxxxx; tony.luck@xxxxxxxxx;
> james.morse@xxxxxxx; rrichter@xxxxxxxxxxx; Michal Simek
> <michals@xxxxxxxxxx>; Manish Narani <MNARANI@xxxxxxxxxx>
> Cc: linux-edac@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> imx@xxxxxxx; frank.li@xxxxxxx
> Subject: [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col parameter
>
> Since ZynqMP platform call zynqmp_get_error_info() function to get ce/ue
> information. In this function, pinf->col parameter is not used, this
> parameter is only used by Zynq platforme in zynq_get_error_info(). So
> here pinf->col should not be called and printed for ZynqMP, need remove
> it.
>
> Fixes: b500b4a029d57 ("EDAC, synopsys: Add ECC support for ZynqMP DDR
> controller")
> Signed-off-by: Sherry Sun <sherry.sun@xxxxxxx>

Reviewed-by: Manish Narani <manish.narani@xxxxxxxxxx>

Thanks,
Manish