Re: [PATCH v2 3/5] usb: musb: jz4740: Register USB role switch

From: Bin Liu
Date: Mon Mar 09 2020 - 11:39:21 EST


Hi,

On Sun, Feb 23, 2020 at 10:40:06PM -0300, Paul Cercueil wrote:
> Register a USB role switch, in order to get notified by the connector
> driver when the USB role changes. The notification is then transmitted
> to the PHY.
>
> Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> ---
>
> Notes:
> v2: No change
>
> drivers/usb/musb/Kconfig | 1 +
> drivers/usb/musb/jz4740.c | 46 +++++++++++++++++++++++++++++++++++++++
> 2 files changed, 47 insertions(+)
>
> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
> index c4b349e074c1..3268adb7d7cf 100644
> --- a/drivers/usb/musb/Kconfig
> +++ b/drivers/usb/musb/Kconfig
> @@ -113,6 +113,7 @@ config USB_MUSB_JZ4740
> depends on MIPS || COMPILE_TEST
> depends on USB_MUSB_GADGET
> depends on USB=n || USB_OTG_BLACKLIST_HUB
> + select USB_ROLE_SWITCH
>
> config USB_MUSB_MEDIATEK
> tristate "MediaTek platforms"
> diff --git a/drivers/usb/musb/jz4740.c b/drivers/usb/musb/jz4740.c
> index aa32b5af0c1f..bbfeb9881788 100644
> --- a/drivers/usb/musb/jz4740.c
> +++ b/drivers/usb/musb/jz4740.c
> @@ -12,13 +12,16 @@
> #include <linux/module.h>
> #include <linux/of_device.h>
> #include <linux/platform_device.h>
> +#include <linux/usb/role.h>
> #include <linux/usb/usb_phy_generic.h>
>
> #include "musb_core.h"
>
> struct jz4740_glue {
> struct platform_device *pdev;
> + struct musb *musb;
> struct clk *clk;
> + struct usb_role_switch *role_sw;
> };
>
> static irqreturn_t jz4740_musb_interrupt(int irq, void *__hci)
> @@ -72,11 +75,38 @@ static const struct musb_hdrc_config jz4740_musb_config = {
> .fifo_cfg_size = ARRAY_SIZE(jz4740_musb_fifo_cfg),
> };
>
> +static int jz4740_musb_role_switch_set(struct device *dev, enum usb_role role)

The prototype has been changed by bce3052f0c16 ("usb: roles: Provide the
switch drivers handle to the switch in the API"). Please update.

Thanks,
-Bin.